Skip to content

🌱 [release-1.9] Bump go version to 1.24.10 #12969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: release-1.9
Choose a base branch
from
Open

🌱 [release-1.9] Bump go version to 1.24.10 #12969

wants to merge 2 commits into from

Conversation

@arshadd-b
Copy link
Contributor

@arshadd-b arshadd-b commented Nov 7, 2025

What this PR does / why we need it:
Bump GoVersion to 1.24.9
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Nov 7, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 7, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 7, 2025
@sbueringer sbueringer added the area/dependency Issues or PRs related to dependency changes label Nov 7, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Nov 7, 2025
sbueringer
sbueringer reviewed Nov 7, 2025
View reviewed changes
@arshadd-b arshadd-b changed the title 🌱 [release-1.9] Bump go version to 1.24.9 🌱 [release-1.9] Bump go version to 1.24.10 Nov 7, 2025
@arshadd-b
Copy link
Contributor Author

arshadd-b commented Nov 7, 2025

looks like lot of lint issues , thinking to increase the golint version to 1.61 and check

@sbueringer
Copy link
Member

sbueringer commented Nov 7, 2025

Hm almost look like compile issues

In general I would be fine with adding excludes instead of fixing lint findings

@sbueringer
Copy link
Member

sbueringer commented Nov 7, 2025 •
edited
Loading

Tested v1.64.3, looks better. Let's bump to v1.64.3. But please let's make only the same fixes we made on release-1.10 + some additional ones in unit test files are fine.

If there are more findings, let's use //nolint: for them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

No one assigned

Labels

area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.9

Development

Successfully merging this pull request may close these issues.

3 participants

@arshadd-b @k8s-ci-robot @sbueringer